Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step Function] 3.1 Refactor code for getting Lambda config #147

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Jan 7, 2025

Context of this PR series

Right now the Datadog Serverless CloudFormation Macro only supports instrumenting Lambda functions. This series of PRs makes it also support instrumenting Step Functions.

Instead of merging every PR into main branch, I'm going to merge them into a feature branch yiming.luo/step-function to:

  1. respect the holiday production freeze
  2. avoid releasing partial support for step functions

What does this PR do?

Moves the code for getting Lambda config from index.ts to lambda/env.ts.

Motivation

I'm going to add similar code (for getting config) for step functions. Putting it also in index.ts, as the Lambda code currently does, would make that file messy.

Testing Guidelines

  1. Pass the existing automated tests in lambda/env.spec.ts

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner January 7, 2025 18:52
@lym953 lym953 requested review from a team and hannahqjiang January 7, 2025 18:52
@lym953 lym953 marked this pull request as draft January 7, 2025 19:00
Base automatically changed from yiming.luo/step-function-7 to yiming.luo/step-function January 7, 2025 22:51
@lym953 lym953 force-pushed the yiming.luo/step-function-8 branch from 0d22b39 to 95c89a1 Compare January 7, 2025 22:52
@lym953 lym953 marked this pull request as ready for review January 7, 2025 22:54
@lym953 lym953 merged commit 46d4883 into yiming.luo/step-function Jan 7, 2025
10 checks passed
@lym953 lym953 deleted the yiming.luo/step-function-8 branch January 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants