[Step Function] 3.3. Add class StepFunctionConfigLoader #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
commented
Jan 8, 2025
| @@ -21,7 +22,7 @@ export async function instrumentStateMachines(event: InputEvent): Promise<Output | |||
| }; | |||
| } | |||
|
|
|||
| function instrumentStateMachine(resources: Resources, stateMachine: StateMachine): void { | |||
| function instrumentStateMachine(resources: Resources, config: Configuration, stateMachine: StateMachine): void { | |||
There was a problem hiding this comment.
config will be used in future PRs.
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| fragment: { | ||
| Mappings: {}, | ||
| }, | ||
| } as any; |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unsafe assignment of an `any` value. (...read more)
The any type in TypeScript is dangerously broad, leading to unexpected behavior. Using any should be avoided.
avangelillo
approved these changes
Jan 8, 2025
Base automatically changed from
yiming.luo/step-function-9-1
to
yiming.luo/step-function
January 8, 2025 19:13
lym953
force-pushed
the
yiming.luo/step-function-10
branch
from
578ddba to
2442c34
Compare
| fragment: { | ||
| Mappings: {}, | ||
| }, | ||
| } as any; |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unsafe assignment of an `any` value. (...read more)
The any type in TypeScript is dangerously broad, leading to unexpected behavior. Using any should be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of this PR series
Right now the Datadog Serverless CloudFormation Macro only supports instrumenting Lambda functions. This series of PRs makes it also support instrumenting Step Functions.
Instead of merging every PR into main branch, I'm going to merge them into a feature branch
yiming.luo/step-functionto avoid releasing partial support for step functions.What does this PR do?
Similar to the existing class
LambdaConfigLoadercreated in #150, this PR adds a classStepFunctionConfigLoader, which extends the same base classConfigLoader.Motivation
To load step function config options set by the user, e.g.
env.Testing Guidelines
step_function/env.spec.tsAdditional Notes
env.spec.ts, I can only use theenvfield, which is the only field for now. One problem is that it doesn't have a default value, so I can't test the behavior around default values. I will change to another field once there is one.Types of changes
Check all that apply