[Step Function] 8.1 Fix subscription filter creation failure #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
force-pushed
the
yiming.luo/step-function-23
branch
from
da50a70 to
a043764
Compare
lym953
force-pushed
the
yiming.luo/step-function-22
branch
from
14a1fb8 to
0a1df02
Compare
Base automatically changed from
yiming.luo/step-function-22
to
yiming.luo/step-function
January 17, 2025 17:30
lym953
force-pushed
the
yiming.luo/step-function-23
branch
from
a043764 to
975a7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of this PR series
Right now the Datadog Serverless CloudFormation Macro only supports instrumenting Lambda functions. This series of PRs makes it also support instrumenting Step Functions.
Instead of merging every PR into main branch, I'm going to merge them into a feature branch
yiming.luo/step-functionto avoid releasing partial support for step functionsProblem this PR solves
When I deploy an application stack that includes a step function and uses our CloudFormation Macro, deployment fails when creating the log group subscription filter. It says the log group is not found.
What does this PR do?
Add a
DependsOnfield to specify that the subscription filter depends on the log group.Testing Guidelines
Automated testing
Deploy the CloudFormation Macro stack then the application stack. The application stack could deploy successfully. Both the log group and the subscription filter were created.
Additional Notes
Types of changes
Check all that apply