fix: tagObject to avoid ignoring booleans (#388)

* fix `tagObject` to not ignore booleans * lint
DataDog · May 3, 2023 · 22627ab · 22627ab
1 parent 14f4be7
commit 22627ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/utils/tag-object.spec.ts b/src/utils/tag-object.spec.ts
@@ -22,18 +22,22 @@ describe("tagObject", () => {
         keyOne: "foobar",
         myObject: {
           anotherKey: ["array", "of", "values"],
+          nestedBoolean: false,
         },
         val: null,
         number: 1,
+        aBoolean: true,
       },
     });
     expect(setTag.mock.calls).toEqual([
       ["lambda_payload.request.keyOne", "foobar"],
       ["lambda_payload.request.myObject.anotherKey.0", "array"],
       ["lambda_payload.request.myObject.anotherKey.1", "of"],
       ["lambda_payload.request.myObject.anotherKey.2", "values"],
+      ["lambda_payload.request.myObject.nestedBoolean", false],
       ["lambda_payload.request.val", null],
       ["lambda_payload.request.number", 1],
+      ["lambda_payload.request.aBoolean", true],
     ]);
   });
   it("tags arrays of objects", () => {

diff --git a/src/utils/tag-object.ts b/src/utils/tag-object.ts
@@ -20,7 +20,7 @@ export function tagObject(currentSpan: any, key: string, obj: any, depth = 0): a
     }
     return tagObject(currentSpan, key, parsed, depth);
   }
-  if (typeof obj === "number") {
+  if (typeof obj === "number" || typeof obj === "boolean") {
     return currentSpan.setTag(key, obj);
   }
   if (typeof obj === "object") {