Use aws-sdk v3 for secrets manager (#616)

* use v3 aws sdk * adjust test * pin to version last supporting ndoe 16
DataDog · Feb 5, 2025 · 4724a63 · 4724a63
1 parent c163362
commit 4724a63
Show file tree

Hide file tree

Showing 4 changed files with 723 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -21,6 +21,7 @@
   },
   "devDependencies": {
     "@aws-sdk/client-kms": "^3.366.0",
+    "@aws-sdk/client-secrets-manager": "^3.721.0",
     "@types/aws-lambda": "^8.10.136",
     "@types/aws-sdk": "^2.7.0",
     "@types/jest": "^26.0.23",

diff --git a/src/metrics/listener.spec.ts b/src/metrics/listener.spec.ts
@@ -9,14 +9,12 @@ import StatsDClient from "hot-shots";
 import { Context } from "aws-lambda";
 jest.mock("hot-shots");
 
-jest.mock("aws-sdk/clients/secretsmanager", () => {
-  return jest.fn().mockImplementation(() => ({
-    getSecretValue: jest.fn().mockReturnValue({
-      promise: jest.fn().mockResolvedValue({
-        SecretString: "api-key-secret",
-      }),
-    }),
-  }));
+jest.mock("@aws-sdk/client-secrets-manager", () => {
+  return {
+    SecretsManager: jest.fn().mockImplementation(() => ({
+      getSecretValue: jest.fn().mockResolvedValue({ SecretString: "api-key-secret" }),
+    })),
+  };
 });
 
 const siteURL = "example.com";

diff --git a/src/metrics/listener.ts b/src/metrics/listener.ts
@@ -222,9 +222,9 @@ export class MetricsListener {
 
     if (config.apiKeySecretARN !== "") {
       try {
-        const { default: secretsClient } = await import("aws-sdk/clients/secretsmanager");
-        const secretsManager = new secretsClient();
-        const secret = await secretsManager.getSecretValue({ SecretId: config.apiKeySecretARN }).promise();
+        const { SecretsManager } = await import("@aws-sdk/client-secrets-manager");
+        const secretsManager = new SecretsManager();
+        const secret = await secretsManager.getSecretValue({ SecretId: config.apiKeySecretARN });
         return secret?.SecretString ?? "";
       } catch (error) {
         logError("couldn't get secrets manager api key", error as Error);