Disable the fs module integration by default in the tracer
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 90.22% 90.01% -0.22%
==========================================
Files 26 26
Lines 839 841 +2
Branches 142 143 +1
==========================================
Hits 757 757
- Misses 54 56 +2
Partials 28 28
Continue to review full report at Codecov.
|
nhinsch
reviewed
Sep 29, 2020
tianchu
reviewed
Sep 29, 2020
README.md
Outdated
| @@ -104,6 +104,10 @@ Inject Datadog trace id into logs for correlation. Defaults to `true`. | |||
|
|
|||
| Set to `true` to merge the X-Ray trace and the Datadog trace, when using both the X-Ray and Datadog tracing. Defaults to `false`. | |||
|
|
|||
| ### DD_TRACE_DISABLED_PLUGINS | |||
There was a problem hiding this comment.
Since this is not directly supported by datadog-lambda, Should we simply add a paragraph about the environment variables that are honored by dd-trace and a link to that list? https://docs.datadoghq.com/tracing/setup/nodejs/#configuration
nhinsch
reviewed
Oct 5, 2020
README.md
Outdated
| @@ -26,6 +26,8 @@ For additional details on trace collection, take a look at [collecting traces fr | |||
|
|
|||
| For additional details on trace and log connection, check out the [official documentation for Datadog trace client](https://datadoghq.dev/dd-trace-js/). | |||
|
|
|||
| The `fs` module is disabled by default. If you want to enable it you have to set the environmental variable `DD_TRACE_DISABLED_PLUGINS` to `''` or to a comma separated list of the plugins you want to disable. See the full list of supported plugins [here](https://docs.datadoghq.com/tracing/compatibility_requirements/nodejs/). | |||
There was a problem hiding this comment.
environmental variable -> environment variable
comma separated list -> comma-separated list
nhinsch
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fsmodule integration indd-trace.http-errorsfrom integration tests as they really don't provide a lot of value and timeout sporadically because they have an external dependencyIn order to enable a user can set
DD_TRACE_DISABLED_PLUGINSto''otherwise it will be disabled by default.Since the user can already disable other integration in the tracer using
DD_TRACE_DISABLED_PLUGINSwe make sure we don't overwrite the env var and only append to it if it exists.Motivation
This confuses a lot of customers and the amount of data we log. This will decrease the number of support cases as well.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply