Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up socket after sending payload to x-ray #114

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Socket for send X-Ray sdk payload wasn't being cleaned up correctly, and was causing system to run out of sockets.

Motivation

Fix for issue #113 .

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner October 19, 2020 14:10
@DarcyRaynerDD DarcyRaynerDD merged commit 839cbc7 into master Oct 19, 2020
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-socket-issue branch October 19, 2020 14:49
@dncrews
Copy link

dncrews commented Dec 19, 2020

@DarcyRaynerDD late to the party, but thank you for this. This has been causing us immeasurable headache over the last few months, and we couldn't figure out where the "memory leak" (file-descriptors leak, tho) was coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants