Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy issue with context.done callbacks #118

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Fixes issue where lambda wrapper was never completes, due to an undocumented/deprecated API for completing the invocation. See here

Motivation

Because the wrapper was never completing, but the invocation was, trace spans would end up joined together in a mega trace.

Testing Guidelines

I've added unit tests, and also tested this manually to verify the fix.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner October 21, 2020 18:42
@DarcyRaynerDD DarcyRaynerDD merged commit c646c70 into master Oct 21, 2020
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/wrap-context-success branch October 21, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants