Fix legacy issue with context.done callbacks #118
Merged
+87
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where lambda wrapper was never completes, due to an undocumented/deprecated API for completing the invocation. See here
Motivation
Because the wrapper was never completing, but the invocation was, trace spans would end up joined together in a mega trace.
Testing Guidelines
I've added unit tests, and also tested this manually to verify the fix.
Additional Notes
Types of Changes
Check all that apply