Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with closing xray socket too early #124

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Fixes an issue with the x-ray socket being closed too early. This causes metadata to not be submitted to x-ray.

Motivation

Discovered while testing

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner November 10, 2020 16:35
@DarcyRaynerDD DarcyRaynerDD merged commit acd03f2 into master Nov 10, 2020
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-socket-close branch November 10, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants