Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop node12.x from publish script #378

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 10, 2023

What does this PR do?

Unfortunately this caused an off by one error where we'd apply the wrong compatible-runtime flag to published layers.
image

Fortunately this flag is not actually enforced in Lambda, and is a label only. So this has no runtime implications.

Searching the publish_layers codebase, we see this is only used for setting this flag.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner April 10, 2023 15:33
@astuyve astuyve merged commit 39836a0 into main Apr 10, 2023
@astuyve astuyve deleted the aj/drop-node12-from-publish branch April 10, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants