Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH [SVLS-3853] #430

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Nov 7, 2023

What does this PR do?

  1. Expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH environment variable. This is to achieve feature parity. Universal instrumentation already enabled the env: [Serverless] Capture lambda payload as tags datadog-agent#19450
  2. Add a section in Readme file to serve as a doc for the environment variables introduced in this repo.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner November 7, 2023 18:29
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (35295b3) 80.35% compared to head (8ed18b2) 81.27%.
Report is 83 commits behind head on main.

❗ Current head 8ed18b2 differs from pull request most recent head 9be5811. Consider uploading reports for the commit 9be5811 to get more accurate results

Files Patch % Lines
src/trace/step-function-service.ts 49.29% 35 Missing and 1 partial ⚠️
src/trace/listener.ts 41.37% 17 Missing ⚠️
src/trace/span-inferrer.ts 81.48% 0 Missing and 10 partials ⚠️
src/trace/cold-start-tracer.ts 87.23% 2 Missing and 4 partials ⚠️
src/trace/xray-service.ts 94.59% 5 Missing and 1 partial ⚠️
src/trace/context/extractors/event-bridge-sqs.ts 61.53% 3 Missing and 2 partials ⚠️
src/index.ts 90.47% 3 Missing and 1 partial ⚠️
src/trace/context/extractor.ts 95.18% 4 Missing ⚠️
src/trace/context/extractors/event-bridge.ts 63.63% 3 Missing and 1 partial ⚠️
src/trace/context/extractors/kinesis.ts 69.23% 3 Missing and 1 partial ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   80.35%   81.27%   +0.92%     
==========================================
  Files          36       50      +14     
  Lines        1761     2040     +279     
  Branches      410      467      +57     
==========================================
+ Hits         1415     1658     +243     
- Misses        294      322      +28     
- Partials       52       60       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeyzhao2018 joeyzhao2018 force-pushed the joey/capture_payload_depth branch from 9b99ace to eac7b63 Compare November 10, 2023 16:36
@joeyzhao2018 joeyzhao2018 changed the title expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH [SLVS-3853] expose DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH [SVLS-3853] Nov 11, 2023
@joeyzhao2018 joeyzhao2018 force-pushed the joey/capture_payload_depth branch from 9be5811 to 6988396 Compare December 5, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants