feat: Skip the flush() call unless the DD_LOCAL_TEST env var is set #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
approved these changes
Dec 18, 2023
joeyzhao2018
approved these changes
Dec 18, 2023
src/index.ts
Outdated
| @@ -365,6 +367,11 @@ function getConfig(userConfig?: Partial<Config>): Config { | |||
| config.captureLambdaPayloadMaxDepth = Number(getEnvValue(captureLambdaPayloadMaxDepthEnvVar, "10")); | |||
| } | |||
|
|
|||
| if (userConfig === undefined || userConfig.localTesting === undefined) { | |||
| const result = getEnvValue(localTestingEnvVar, "false").toLowerCase(); | |||
| config.localTesting = result === "true"; | |||
There was a problem hiding this comment.
The extension also allows for DD_LOCAL_TEST=1
There was a problem hiding this comment.
Fixed – but this shouldn't ever have been done and should be removed.
purple4reina
requested changes
Dec 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 82.06% 82.09% +0.03%
==========================================
Files 54 54
Lines 2180 2184 +4
Branches 507 509 +2
==========================================
+ Hits 1789 1793 +4
Misses 329 329
Partials 62 62 ☔ View full report in Codecov by Sentry. |
purple4reina
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the call to
/flush, as the telemetry-api tells us this information nowFixes #452
Motivation
We'd like to remove this entirely but it's required for people using the extension in a local testing mode. We don't intend to further support local testing in this library at this time.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply