Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLES-1463] [SLES-1454] Fix id.toArray() issue #455

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Dec 20, 2023

What does this PR do?

Fix #444

Motivation

Testing Guidelines

Screenshot 2023-12-20 at 2 33 17 PM

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner December 20, 2023 19:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b32baa9) 82.09% compared to head (8151ab1) 82.10%.

❗ Current head 8151ab1 differs from pull request most recent head 0d1421a. Consider uploading reports for the commit 0d1421a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   82.09%   82.10%           
=======================================
  Files          54       54           
  Lines        2184     2185    +1     
  Branches      509      509           
=======================================
+ Hits         1793     1794    +1     
  Misses        329      329           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeyzhao2018 joeyzhao2018 merged commit f116ecb into main Dec 20, 2023
@joeyzhao2018 joeyzhao2018 deleted the joey/toarray-issue branch December 20, 2023 19:34
@joeyzhao2018 joeyzhao2018 changed the title Fix id.toArray() issue [SLES-1463] Fix id.toArray() issue Dec 20, 2023
@joeyzhao2018 joeyzhao2018 changed the title [SLES-1463] Fix id.toArray() issue [SLES-1463] [SLES-1454] Fix id.toArray() issue Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNSResolvePlugin.finish throws TypeError
3 participants