Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVLS-3853] handle empty function case in tag-object #467

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Jan 24, 2024

What does this PR do?

Fixes #464 (again, 😭 )

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner January 24, 2024 15:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 117 lines in your changes are missing coverage. Please review.

Comparison is base (35295b3) 80.35% compared to head (d57c29f) 82.12%.
Report is 99 commits behind head on main.

❗ Current head d57c29f differs from pull request most recent head 626f525. Consider uploading reports for the commit 626f525 to get more accurate results

Files Patch % Lines
src/trace/listener.ts 53.84% 17 Missing and 1 partial ⚠️
src/trace/span-context-wrapper.ts 57.57% 13 Missing and 1 partial ⚠️
src/trace/span-inferrer.ts 83.33% 0 Missing and 10 partials ⚠️
src/trace/xray-service.ts 91.50% 8 Missing and 1 partial ⚠️
src/trace/step-function-service.ts 92.13% 6 Missing and 1 partial ⚠️
src/trace/cold-start-tracer.ts 87.23% 2 Missing and 4 partials ⚠️
src/utils/event-type-guards.ts 14.28% 6 Missing ⚠️
src/trace/context/extractor.ts 91.07% 5 Missing ⚠️
src/trace/context/extractors/sqs.ts 66.66% 4 Missing and 1 partial ⚠️
src/index.ts 91.66% 3 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   80.35%   82.12%   +1.77%     
==========================================
  Files          36       54      +18     
  Lines        1761     2188     +427     
  Branches      410      510     +100     
==========================================
+ Hits         1415     1797     +382     
- Misses        294      329      +35     
- Partials       52       62      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeyzhao2018 joeyzhao2018 merged commit 6f692fb into main Jan 24, 2024
40 checks passed
@joeyzhao2018 joeyzhao2018 deleted the joey/empty_func_tag_object branch January 24, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError exception raised when tracing is capturing request/response payloads
3 participants