Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate Node.js 14.x #486

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Drops support for Node.js 14.x.

Motivation

Since it is in deprecation phase 2 by AWS.

Testing Guidelines

Automated checks.

Additional Notes

There's a note about dc-polyfill which we should check. Not done in this PR yet.

// TODO NEXT MAJOR (AJ): Remove this when we drop node14
const dc = require('dc-polyfill')

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista requested a review from a team as a code owner February 12, 2024 21:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (039b04e) 82.13% compared to head (0319c1e) 82.11%.

❗ Current head 0319c1e differs from pull request most recent head 66c3ccd. Consider uploading reports for the commit 66c3ccd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   82.13%   82.11%   -0.03%     
==========================================
  Files          54       54              
  Lines        2189     2186       -3     
  Branches      510      509       -1     
==========================================
- Hits         1798     1795       -3     
  Misses        329      329              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanista duncanista merged commit 0fe831a into main Feb 13, 2024
25 checks passed
@duncanista duncanista deleted the jordan.gonzalez/deprecate-node14.x branch February 13, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants