-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate Node.js 14.x #486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 82.13% 82.11% -0.03%
==========================================
Files 54 54
Lines 2189 2186 -3
Branches 510 509 -1
==========================================
- Hits 1798 1795 -3
Misses 329 329
Partials 62 62 ☔ View full report in Codecov by Sentry. |
purple4reina
approved these changes
Feb 12, 2024
…/DataDog/datadog-lambda-js into jordan.gonzalez/deprecate-node14.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Drops support for Node.js 14.x.
Motivation
Since it is in deprecation phase 2 by AWS.
Testing Guidelines
Automated checks.
Additional Notes
There's a note about
dc-polyfill
which we should check. Not done in this PR yet.datadog-lambda-js/src/runtime/require-tracer.ts
Lines 1 to 3 in 039b04e
Types of Changes
Check all that apply