Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump ddtrace to 4.x (breaking change) #487

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat: bump ddtrace to 4.x (breaking change) #487

merged 2 commits into from
Feb 13, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Feb 13, 2024

What does this PR do?

This library is dropping support for node14, so we can now upgrade ddtrace to 4.x

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve marked this pull request as ready for review February 13, 2024 18:00
@astuyve astuyve requested a review from a team as a code owner February 13, 2024 18:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fe831a) 82.11% compared to head (181e468) 82.11%.

❗ Current head 181e468 differs from pull request most recent head 7adccb0. Consider uploading reports for the commit 7adccb0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          54       54           
  Lines        2186     2186           
  Branches      509      509           
=======================================
  Hits         1795     1795           
  Misses        329      329           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astuyve astuyve merged commit 715e2b5 into main Feb 13, 2024
25 checks passed
@astuyve astuyve deleted the aj/dd-trace-4.x branch February 13, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants