Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#491: adding compression to metrics API #492

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

nagydaoudt
Copy link
Contributor

What does this PR do?

It's addressing #491, Adding deflate compression to metrics API

Motivation

Testing Guidelines

By adding a test, I don't have an AWS account, So maybe you can help me run the integration tests

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nagydaoudt nagydaoudt requested a review from a team as a code owner February 29, 2024 11:23
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, thanks for the PR. One thing we should chante

Some users are using the datadog lambda extension where this proposed DD_COMPRESS_METRIC_PAYLOAD env var would not be honored.

Let's remove it and use compression all the time, which is what datadog-lambda-python does. That should simplify the implementation as well. I can run it through our test bed and see if it creates extra latency, but given that I expect most payloads to be small, it should be fine. That is unless users are pushing massive numbers of metrics and thus would want compression.

Thanks!

@nagydaoudt
Copy link
Contributor Author

@astuyve
Copy link
Contributor

astuyve commented Feb 29, 2024

Yup! Should make the implementation easier, just rip out the config boolean everywhere.

Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! (just need to run prettier)

@astuyve
Copy link
Contributor

astuyve commented Feb 29, 2024

Our CI won't run on a fork, I'll merge this and let the integration tests run. I'll update the github issue when this is released.

Thanks again!

@astuyve astuyve merged commit 9205b7b into DataDog:main Feb 29, 2024
9 checks passed
@astuyve
Copy link
Contributor

astuyve commented Mar 8, 2024

This is released in 8.107.0 and layer v107!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants