-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#491: adding compression to metrics API #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, thanks for the PR. One thing we should chante
Some users are using the datadog lambda extension where this proposed DD_COMPRESS_METRIC_PAYLOAD
env var would not be honored.
Let's remove it and use compression all the time, which is what datadog-lambda-python does. That should simplify the implementation as well. I can run it through our test bed and see if it creates extra latency, but given that I expect most payloads to be small, it should be fine. That is unless users are pushing massive numbers of metrics and thus would want compression.
Thanks!
@astuyve |
Yup! Should make the implementation easier, just rip out the config boolean everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution! (just need to run prettier)
Our CI won't run on a fork, I'll merge this and let the integration tests run. I'll update the github issue when this is released. Thanks again! |
This is released in 8.107.0 and layer v107! |
What does this PR do?
It's addressing #491, Adding deflate compression to metrics API
Motivation
Testing Guidelines
By adding a test, I don't have an AWS account, So maybe you can help me run the integration tests
Types of Changes
Check all that apply