Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sending metrics before handler initialization #524

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Mar 22, 2024

What does this PR do?

Allows customer to use the API sendDistributionMetric and sendDistributionMetricWithDate outside of the handler.

Motivation

#515

Testing Guidelines

  • Added unit tests
  • Added integration test
  • Tested manually

Additional Notes

SVLS-4633

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.89%. Comparing base (dadad52) to head (5b2885d).

❗ Current head 5b2885d differs from pull request most recent head 59d713d. Consider uploading reports for the commit 59d713d to get more accurate results

Files Patch % Lines
src/index.ts 60.00% 6 Missing ⚠️
src/utils/log.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   81.75%   81.89%   +0.13%     
==========================================
  Files          54       55       +1     
  Lines        2209     2248      +39     
  Branches      515      519       +4     
==========================================
+ Hits         1806     1841      +35     
- Misses        337      343       +6     
+ Partials       66       64       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanista duncanista marked this pull request as ready for review March 22, 2024 20:57
@duncanista duncanista requested a review from a team as a code owner March 22, 2024 20:57
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reducing time complexity to `O(2n)`
@duncanista duncanista merged commit 6810d0c into main Mar 26, 2024
25 checks passed
@duncanista duncanista deleted the jordan.gonzalez/queue-metrics branch March 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants