-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVLS-4999] Add Lambda tags to metrics sent via the API #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanLovesCoffee
commented
Jul 1, 2024
duncanista
reviewed
Jul 2, 2024
duncanista
reviewed
Jul 2, 2024
duncanista
reviewed
Jul 15, 2024
duncanista
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the Extension is present, the Lambda library will use the DD API to send distribution metrics with timestamps instead of the Extension, since the Extension does not support historical distribution metrics. Metrics sent via the API currently do not get tagged with Lambda tags.
This adds some essential tags like those added via

DD_TAGS
and thefunction_arn
. With thefunction_arn
tag available, custom metrics will be enriched with other tags collected by the metadata crawler if the AWS integration is enabled:Also added a warning log for historical distribution metrics that are sent to the API with an unsupported timestamp (>=4hrs).

Motivation
DataDog/datadog-lambda-python#398 and #545
Testing Guidelines
Built the layer and tested manually.
Additional Notes
Types of Changes
Check all that apply