Step Functions Trace Merging Support #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -3,23 +3,57 @@ import { SampleMode, TraceSource } from "./trace-context-service"; | |||
| import { SpanContextWrapper } from "./span-context-wrapper"; | |||
| import { Sha256 } from "@aws-crypto/sha256-js"; | |||
|
|
|||
| export interface StepFunctionContext { | |||
There was a problem hiding this comment.
since the context is also used as tags here code line can we clarify why the change of the tags in the PR description?
There was a problem hiding this comment.
oh i think you explained it by "Also fixed the trigger tags parsing for our use case!" Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows us to do multi-level trace merging between Step Functions and Node Lambda functions
multi-level trace merging
Added logic to extract trace context from
_datadogfor Step Functions cases where...x-datadog-trace-idandx-datadog-tagsbut we need to compute the parentID using parent SFN context objectRootExecutionIdand the parent SFN context object_datadogand we instead figure out traceID and parentID from the parent SFN context objectlive testing
Lambda1 --> SFN --> Lambda2tracea. Lambda1 is actually in Python, cool how we can mix and match runtimes
SFN --> Lambdatracetrigger tag improvements
Also fixed the trigger tags parsing for our use case!
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply