Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract API Key from Secrets Manager when using the metrics API client #609

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

DylanLovesCoffee
Copy link
Contributor

@DylanLovesCoffee DylanLovesCoffee commented Jan 22, 2025

What does this PR do?

Respects DD_API_KEY_SECRET_ARN as an API key parameter when using the DD metrics API client since this logic was never added.

Motivation

#577 - permission errors are thrown for Secrets Manager when using sendDistributionMetricWithDate() and DD_API_KEY_SECRET_ARN.

Testing Guidelines

Adds a unit test for secrets manager

Additional Notes

SVLS-5679

This will likely add a bit of overhead due to having to load the Secrets Manager AWS SDK, but this logic is lazy loaded and only hit when a metric is sent to the DD metrics API (most often used to send metrics with a retro timestamp).

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner January 22, 2025 20:14
@DylanLovesCoffee DylanLovesCoffee merged commit eb74c9c into main Jan 23, 2025
30 checks passed
@DylanLovesCoffee DylanLovesCoffee deleted the dylan/get-secret-api-key branch January 23, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants