Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] Get secrets from vault #620

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Feb 13, 2025

What does this PR do?

Migrates secret storage from AWS SSM to Vault.
Secrets: https://vault.us1.ddbuild.io/ui/vault/secrets/kv/kv/k8s%2Fgitlab-runner%2Fdatadog-lambda-js%2Fsecrets/details?version=2

Motivation

Proper secret storage in Gitlab: https://datadoghq.atlassian.net/wiki/spaces/SECENG/pages/3826647944/Secure+Storage+and+Handling+of+Secrets#In-GitLab

Testing Guidelines

Additional Notes

Related PR: https://github.com/DataDog/vault-config/pull/7119

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston force-pushed the nicholas.hulston/migrate-gitlab-secrets-to-vault branch from 3977ae3 to 194a1a3 Compare February 13, 2025 16:54
@nhulston nhulston force-pushed the nicholas.hulston/migrate-gitlab-secrets-to-vault branch from 194a1a3 to ea0eb1c Compare February 13, 2025 17:05
@nhulston nhulston marked this pull request as ready for review February 13, 2025 17:45
@nhulston nhulston requested a review from a team as a code owner February 13, 2025 17:45
@nhulston nhulston merged commit 7d8e605 into main Feb 13, 2025
30 checks passed
@nhulston nhulston deleted the nicholas.hulston/migrate-gitlab-secrets-to-vault branch February 13, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants