Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bundle and publish to govcloud script #627

Merged

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Feb 28, 2025

What does this PR do?

Creates a job in Gitlab to bundle all the layer zips into a single zip so we no longer have to manually download each layer manually.

This PR also creates scripts/publish_govcloud_layers.sh to publish layers to either Govcloud or Govcloud staging.

Motivation

Copying logic from DataDog/datadog-lambda-extension#556

Easier testing of layers for FIPs compliance + easier time publishing to Govcloud

Testing Guidelines

Manually.

Layer bundle passed:
Screenshot 2025-02-28 at 11 56 31 AM

and produces the correct artifact as expected:
Screenshot 2025-02-28 at 11 56 53 AM

and running the script (on staging) works as expected:

ENVIRONMENT=us1-staging-fed REGIONS=us-gov-west-1 ./scripts/publish_govcloud_layers.sh <path from dragging bundle.zip file>
Screenshot 2025-02-28 at 11 58 02 AM

Additional Notes

Basically all the same logic as the datadog-lambda-extension implementation. But there is no 'flavors' since each layer works on both arm64 and amd64 Lambdas.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston requested a review from a team as a code owner February 28, 2025 16:58
Copy link
Contributor

@apiarian-datadog apiarian-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just make sure we're not setting any unexpected or unnecessary environment variables in the publish_govcloud_layers.sh script.

@nhulston nhulston merged commit a2adc53 into main Mar 3, 2025
25 checks passed
@nhulston nhulston deleted the nicholas.hulston/create-bundle-and-publish-to-govcloud-script branch March 3, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants