Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to support custom timestamp #63

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Added logic to support custom timestamp #63

merged 4 commits into from
Mar 23, 2020

Conversation

vishnuvisnu
Copy link
Contributor

Note: Please remember to review the contribution guidelines
if you have not yet done so.

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Testing Guidelines

How did you test this pull request?

Additional Notes

Anything else we should know when reviewing?

Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one note, but otherwise this looks good to me. Once the CI passes, I'll roll this into the next release

@DarcyRaynerDD DarcyRaynerDD merged commit 412cfb3 into DataDog:master Mar 23, 2020
@DarcyRaynerDD
Copy link
Contributor

Thanks for the PR!

@vishnuvisnu
Copy link
Contributor Author

Thanks for the PR!

No problem, when are you planning your next release?

@DarcyRaynerDD
Copy link
Contributor

We will probably roll out a release some time this week.

@vishnuvisnu
Copy link
Contributor Author

We will probably roll out a release some time this week.

Hi Darcy, Could you please update on progress of the release? Thanks.

@DarcyRaynerDD
Copy link
Contributor

@vishnuvisnu We've just release v2.20.0 of the layer with these changes

@vvo
Copy link

vvo commented Mar 1, 2022

Hey there @vishnuvisnu I understand this is an old issue but I was wondering what's the usecase for setting a custom timestamp? Thanks!

@vishnuvisnu
Copy link
Contributor Author

Hey there @vishnuvisnu I understand this is an old issue but I was wondering what's the usecase for setting a custom timestamp? Thanks!

We have usecase where event was generated was elsewhere and we are converting that event to Datadog metric.

@vvo
Copy link

vvo commented Mar 1, 2022

👍 Thanks a lot for the explanation, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants