Skip and log warning when lambda_metric
called with invalid name or value
#553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
lambda_metric
is called with an invalid name or value, we skip the metric and log a warning. This ensures that if multiple metrics are sent in one lambda invocation and only one is invalid, the rest still get delivered.Motivation
#347
Testing Guidelines
Unit tests
Manual testing; I have a lambda with this handler:
and I see the correct 3 metrics delivered, while seeing logs
Additional Notes
Types of Changes
Check all that apply