Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Filter LIMIT ranges in sql query resources #390

Closed
MDrollette opened this issue Mar 2, 2018 · 1 comment
Closed

Filter LIMIT ranges in sql query resources #390

MDrollette opened this issue Mar 2, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@MDrollette
Copy link

MDrollette commented Mar 2, 2018

Including a LIMIT x, y in a query resource, for example when paging over results, can drastically increase the cardinality of traced resources. I would prefer if LIMIT ranges were filtered out of the query, or replaced with placeholders, by the agent. I could still set the original query on metadata if I wanted to identify the actual values when inspecting traces.

It appears that single LIMIT x is replaced with a LIMIT ? placeholder already. But a range LIMIT x, y is not.

@palazzem palazzem added the core label Mar 5, 2018
@palazzem
Copy link

palazzem commented Mar 5, 2018

Thanks @MDrollette for spotting this! We'll plan some work around it to reduce the cardinality and collapse common queries. We'll keep you updated once we'll start working on it!

@gbbr gbbr self-assigned this Mar 5, 2018
gbbr added a commit that referenced this issue Mar 5, 2018
This change replaces SQL `LIMIT` values (and pairs of values) with `?`
to reduce resource cardinality.

Fixes #390
@gbbr gbbr closed this as completed in #391 Mar 5, 2018
gbbr added a commit that referenced this issue Mar 5, 2018
This change replaces SQL `LIMIT` values (and pairs of values) with `?`
to reduce resource cardinality.

Fixes #390
@palazzem palazzem added this to the 6.1.0 milestone Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants