Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

[decoder] graceful accept uint64 values if they're sent as int64 for ids #190

Merged
merged 1 commit into from
May 11, 2017

Conversation

palazzem
Copy link

What it does

In JRuby interpreter, unsigned int are sent as int type (Java related type system). This patch will handle IDs so that they're cast from int to uint.

@LeoCavaille LeoCavaille added this to the 5.12 milestone Feb 16, 2017
@zaccari
Copy link

zaccari commented Feb 22, 2017

Thank you putting this together. I built the latest version of the trace agent with this code change to see if it resolved the issue for our JRuby 9.1.5.0 application. The error in the trace-agent.log was (pre merging this):

2017-02-22 12:56:45 ERROR (receiver_logger.go:21) - error when decoding msgpack traces

With this change I now see:

2017-02-22 12:45:00 ERROR (receiver_logger.go:23) - cannot decode v0.3 traces payload: msgp: attempted to decode type "int" with method for "uint"

I'm attempting to debug the issue locally, I'll let you know if I'm able to resolve it. In the mean time do you have any suggestions as to why the new error is being thrown?

@ufoot ufoot modified the milestones: 5.13, 5.12 Mar 17, 2017
@ufoot ufoot modified the milestones: 5.14, 5.13 May 10, 2017
@ufoot ufoot merged commit 777fc2a into master May 11, 2017
@palazzem palazzem deleted the palazzem/jruby-decoder-uint branch May 11, 2017 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants