This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
[sampler] reduce log verbosity and exposing state through expvar #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
commented
Mar 17, 2017
agent/sampler.go
Outdated
| state.InTPS, state.OutTPS, state.MaxTPS, state.Offset, state.Slope, state.Cardinality) | ||
|
|
||
| updateSamplerState(state) // publish through expvar | ||
|
|
||
| statsd.Client.Gauge("datadog.trace_agent.sampler.scoring.offset", state.Offset, nil, 1) |
There was a problem hiding this comment.
Open question: should we keep those direct calls to statsd? Because since the values are in expvar, it's rather trivial to get them with https://www.datadoghq.com/blog/instrument-go-apps-expvar-datadog/
LotharSee
approved these changes
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.