This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
writer: don't discard the client on api errors #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our payload buffering logic passes along a stateful `APIEndpoint` when it receives upstream errors. A prior PR added a `client` to individual APIEndpoints without propagating this value to the error handler Thus when an endpoint flush failed, all future flushes would use the zero value for `APIEndpoint.client` which is `nil`
ufoot
approved these changes
Mar 30, 2017
| @@ -124,6 +128,11 @@ func (a *APIEndpoint) Write(p model.AgentPayload) (int, error) { | |||
|
|
|||
| endpointErr := newAPIError() | |||
|
|
|||
| // if this payload cannot be flushed due to API errors | |||
| // we need to pass the client along for future submissions | |||
| // FIXME(aaditya) | |||
There was a problem hiding this comment.
Short-term fix is fine IMHO but as we see this now only, probably no test is going through that path for real. This is beyond the scope of this PR anyway.
| @@ -70,6 +70,7 @@ func NewWriter(conf *config.AgentConfig) *Writer { | |||
| if conf.Proxy != nil { | |||
| // we have some kind of proxy configured. | |||
| // make sure our http client uses it | |||
| log.Infof("configuring proxy through host %s", conf.Proxy.Host) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our payload buffering logic passes along a stateful
APIEndpointwhen it receives upstream errors. A prior PR ( #251 ) added a
clientto individual APIEndpoints without propagating this value to the error handler
Thus when an endpoint flush failed, all future flushes would use the
zero value for
APIEndpoint.clientwhich isnil