Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

tests watchdog: only run TestNetHigh with 200 servers #269

Merged
merged 1 commit into from
May 9, 2017

Conversation

vlad-mh
Copy link

@vlad-mh vlad-mh commented May 4, 2017

On fresh OSX Sierra installs, number of max open file descriptors is set to 256. Thus, the TestNetHigh test with 1000 servers is too much.

I'm not a big fan of this change, but the only other option I see is to ask the developer to change his system settings.

@vlad-mh vlad-mh requested a review from ufoot May 4, 2017 15:48
Copy link

@ufoot ufoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, 200 is way enough. Thanks for spotting this.

On fresh OSX Sierra installs, number of max open file descriptors is set to
256. Thus, the TestNetHigh test with 1000 servers is too much.
@vlad-mh vlad-mh force-pushed the vlad/fix-tests-osx-sierra branch from 96ced23 to 150b7ab Compare May 9, 2017 09:30
@vlad-mh vlad-mh merged commit dea1848 into master May 9, 2017
@dtilghman dtilghman deleted the vlad/fix-tests-osx-sierra branch May 10, 2017 05:14
@LotharSee LotharSee added this to the 5.14 milestone Jun 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants