This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Add timeout between the agent and the backend #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabsn
commented
Sep 20, 2017
•
gabsn
commented
- on staging since 20/09/2017, 11h39
talwai
reviewed
Sep 20, 2017
agent/endpoint.go
Outdated
| @@ -62,7 +62,9 @@ func NewAPIEndpoint(url, apiKey string) *APIEndpoint { | |||
| ae := APIEndpoint{ | |||
| apiKey: apiKey, | |||
| url: url, | |||
| client: http.DefaultClient, | |||
| client: &http.Client{ | |||
| Timeout: 10 * time.Second, | |||
There was a problem hiding this comment.
use a constant. Also this setting will be overriden when we use a proxy, so we need to update it here https://github.com/DataDog/datadog-trace-agent/pull/315/files#L83-L87
talwai
reviewed
Sep 20, 2017
agent/endpoint.go
Outdated
| @@ -15,6 +15,9 @@ import ( | |||
| "github.com/DataDog/datadog-trace-agent/watchdog" | |||
| ) | |||
|
|
|||
| // timeout is used by the agent to release pressure on the backend | |||
There was a problem hiding this comment.
change the comment
// timeout is the HTTP timeout for POST requests to the Datadog backend
talwai
approved these changes
Sep 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.