Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Fix tagStats logging #328

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Fix tagStats logging #328

merged 2 commits into from
Oct 24, 2017

Conversation

LotharSee
Copy link

  • log the actual content of the stats Strings, not its indexes
  • proper strings init, to avoid having empty strings from initialization.
  • hide the empty "" tagStats.

@LotharSee
Fix logging of stats per client tag set
51c89d1
@LotharSee
Hide empty tagStats from logs
fc1196e 
It is legit to have the "" tagStats non-empty as for now we
always attach stats to it, like priority or traces dropped.
So just hide it if it had no trace data for that scope.
@LotharSee LotharSee requested a review from palazzem October 24, 2017 12:14
@palazzem palazzem added this to the 5.18.2 milestone Oct 24, 2017
@palazzem palazzem added the core label Oct 24, 2017
@LotharSee LotharSee merged commit 936fd45 into master Oct 24, 2017
@dtilghman dtilghman deleted the benjamin/fix-log branch October 25, 2017 06:33
@LotharSee LotharSee mentioned this pull request Nov 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
5.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LotharSee @palazzem