This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Graceful shutdown for Windows Service #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
approved these changes
Oct 30, 2017
| elog.Error(1, fmt.Sprintf("unexpected control request #%d", c)) | ||
| exit := make(chan struct{}) | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
This should not have any implication. Something we're missing @talwai?
bmermet
force-pushed
the
bmermet/agentshutdown
branch
from
111dd7b to
475d0dc
Compare
LotharSee
reviewed
Oct 30, 2017
| close(exit) | ||
| return | ||
| default: | ||
| elog.Error(1, fmt.Sprintf("unexpected control request #%d", c)) |
There was a problem hiding this comment.
What could these other command be? Are they all actual errors?
There was a problem hiding this comment.
These are not error indeed, only signals that we don't handle. I'll add your comment in the bigger PR about making the trace-agent work properly as a Windows Service.
LotharSee
approved these changes
Oct 30, 2017
derekwbrown
approved these changes
Oct 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the logic of providing an exit channel out of the
runAgentfunction, that way we can have different exit conditions: