This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
Replace Trace []Span with []*Span #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
force-pushed
the
benjamin/trace-pointer
branch
from
da2fcf3 to
4b0ccf7
Compare
ufoot
approved these changes
Dec 6, 2017
Rakefile
Outdated
|
|
||
| desc "Regenerate messagepack files" | ||
| task :msgp do | ||
| # Actually, don't use it since we modified manually the generated files for |
There was a problem hiding this comment.
Nitpicking, but if we don't use this, a command-like example such as:
puts "don't use it since we modified manually the generated files"
puts "to run it manually: msgp -file=model/span.pb.go -marshal=false"would do the job and get a higher probability not to disappear at next refactoring.
| if err != nil { | ||
| return | ||
| for bzg := range *z { | ||
| if dc.IsNil() { |
There was a problem hiding this comment.
OK, so that's the big difference I guess.
LotharSee
force-pushed
the
benjamin/trace-pointer
branch
from
4b0ccf7 to
0067fb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step before the global introduction of protobuf.
By using references it will simplify the code migration (as generated protobuf structs also include themselves by reference).
That should also avoid various struct copies.
Notes:
model/trace_gen.go, I simply ranmsgp -file=model/trace.go -marshal=false. That should be enough astrace_gen.goisn't a file we manually modified. I also checked to simply regenerate the file without theTracechange and I got exactly the same file as before so the generation method is good.Quantizeis now in-place.