Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

quantizer: support MySQL comments #351

Merged
merged 2 commits into from
Jan 29, 2018
Merged

quantizer: support MySQL comments #351

merged 2 commits into from
Jan 29, 2018

Conversation

palazzem
Copy link

Overview

Updates a contributor PR: #320

It adds support for MySQL comments (inline especially) that are not properly removed from the Agent quantizer:

--- FAIL: TestSQLQuantizer (0.00s)
        Location:       sql_test.go:307
	Error:		Not equal: "select * from users where id = ?" (expected)
			        != "select * from users where id = ? # This comment continues to the end of line" (actual)

This patch solves the problem.

@palazzem palazzem added this to the 5.21.1 milestone Jan 28, 2018
@palazzem palazzem requested a review from LotharSee January 28, 2018 13:04
@palazzem palazzem changed the title [quantizer] support MySQL comments quantizer: support MySQL comments Jan 28, 2018
Copy link

@LotharSee LotharSee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, I thought we were already doing it :/
Test coverage is good. LGTM!

@palazzem palazzem merged commit f947138 into master Jan 29, 2018
@palazzem palazzem deleted the palazzem/mysql-comments branch January 29, 2018 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants