This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
build: upgrade to CircleCI 2.0 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/ci
branch
2 times, most recently
from
8ccda37 to
d56d94d
Compare
LotharSee
reviewed
Feb 19, 2018
.circleci/config.yml
Outdated
| working_directory: /go/src/github.com/DataDog/datadog-trace-agent | ||
|
|
||
| docker: | ||
| - image: circleci/golang:latest # > 1.10 |
There was a problem hiding this comment.
I suggest to stick to the version we use in the build process to be consistent.
(bonus suggestion: let's move to a more recent version of Go in our build chain!)
gbbr
force-pushed
the
gbbr/ci
branch
3 times, most recently
from
4313fc5 to
bb7ea22
Compare
This allows to benefit from caching as well as parallel execution of tests. Running tests one by one is significantly slower.
|
@LotharSee fixed version to 1.8 as per suggestion. I've also enabled the tests to run in parallel, gaining another minute build time. Will take your bonus suggestion into consideration as well in a separate PR, to update our build chain, that will also bring a lot of benefits. |
LotharSee
approved these changes
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces CI time from ~5 min to ~1 min.