Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

build: s/glide/dep #378

Merged
merged 1 commit into from
Feb 22, 2018
Merged

build: s/glide/dep #378

merged 1 commit into from
Feb 22, 2018

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Feb 22, 2018

dep init automatically converted the glide files. Double-checked commits for each dependency.

- windows/svc/debug
- windows/svc/eventlog
- windows/svc/mgr
- package: github.com/golang/protobuf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this package along with datadog-agent and golang.org/x/sys appear in Gopkg.toml in addition to the lock file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my understanding of what the Gopkg.toml file represents, I think that it only holds a set of "hand-written" rules, in this case constraints to certain tags that dep init has found in the glide configuration. I think the repos you've mentioned didn't have these constraints, they've only had commits set.

I would assume that if we ever want to update (using something like dep ensure -update) the toml file will block us from going past the tag in the constraint.

More info here

Copy link

@AlexJF AlexJF Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok the actual explanation for this I guess comes from https://github.com/golang/dep/blob/master/docs/glossary.md#direct-dependency (emphasis mine):

A project's direct dependencies are those that it imports from one or more of its packages, or includes in its required list in Gopkg.toml.

I guess dep automatically adds implicit required entries in Gopkg.toml for detected external imports.

Seems a bit strange to allow hidden implicit dependencies like this though, at least coming from almost any other language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing Alex. Not sure what to say about your strange finding though :)

@gbbr gbbr merged commit 2ec3bb8 into master Feb 22, 2018
@gbbr gbbr deleted the gbbr/dep branch February 22, 2018 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants