Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

vendor: commit dependencies into repository #379

Merged
merged 1 commit into from
Feb 27, 2018
Merged

vendor: commit dependencies into repository #379

merged 1 commit into from
Feb 27, 2018

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Feb 22, 2018

Excluding vendor/ entries from diffs

To view a messy diff that contains vendor updates after this PR is merged, use the exclude: functionality of git 1.9+ like this:

git diff A..B -- . ':(exclude)vendor/'

Pros

  • Faster builds (CI builds 22 seconds)
  • Less dependencies (dep is no longer a dependency, unless needed in development, for updates)
  • Easier deployments (we don't need to download, install and run dep on each OS, every time)
  • Hard copies of each library (no longer relying on network, e.g. site is down making repo unavailable)

Cons

  • Larger repository size (+41MB)
  • Requires new contribution rules (each vendor update should be isolated into it's own PR or commit to avoid messy diffs)

⚠️ Note that this PR does not remove dep, it just commits the vendor folder to simplify builds, deployments and setting up development.

Copy link

@LotharSee LotharSee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, gtm.

Last thing: is it up to date with #382

@gbbr
Copy link
Contributor Author

gbbr commented Feb 27, 2018

Just rebased. All good. Thanks for looking.

@gbbr gbbr merged commit 9da2e7e into master Feb 27, 2018
@gbbr gbbr deleted the gbbr/vendor branch February 27, 2018 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants