This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
writer: inherit and use "skip_ssl_validation" setting from Agent v{5,6} #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/ssl-skip-verify
branch
from
30a51d8 to
6c18533
Compare
LotharSee
reviewed
Mar 9, 2018
config/merge_yaml.go
Outdated
| HostName string `yaml:"hostname"` | ||
| LogLevel string `yaml:"log_level"` | ||
| Proxy proxy `yaml:"proxy"` | ||
| SkipSSLValidation string `yaml:"skip_ssl_validation"` |
There was a problem hiding this comment.
You should make it a *bool (like traceAgent.Enabled) so that you don't have to test manually yes, true, 1, ...
gbbr
force-pushed
the
gbbr/ssl-skip-verify
branch
from
6c18533 to
a7ac6e7
Compare
|
@LotharSee done. PTAL. |
gbbr
commented
Mar 12, 2018
| @@ -67,6 +67,13 @@ func mergeIniConfig(c *AgentConfig, conf *File) error { | |||
| } else if pURL != nil { | |||
| c.ProxyURL = pURL | |||
| } | |||
|
|
|||
| switch m.Key("skip_ssl_validation").MustString("") { | |||
There was a problem hiding this comment.
This package also has a Bool method, but I wasn't sure whether to use it or not. I chose not to, because it wasn't used elsewhere either.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should permit use-cases of running the agent behind a proxy such as
haproxy, using theskip_ssl_validation: truesetting in the config file.