This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
writer: ensure 64bit alignment on 32bit systems #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
approved these changes
Apr 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While letting the trace-agent run on an ARMv7 system (32bit), I encounter some segmentation faults with atomic operations. This is a familiar issue in go, please see https://golang.org/pkg/sync/atomic/#pkg-note-BUG
To fix this, I moved the structs containing the values to be written atomically to the top of the parent struct to ensure that they are 64bit aligned. See link above