This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
info: use bind_host when querying /debug/vars #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where the `info` command was failing due to a non-standard `bind_host` setting. The `info` command was always attempting to reach the /debug/vars endpoint on `localhost`. This would of course not work when the `bind_host` value was different. Fixes DataDog/dd-agent#3653
kevinlebrun
approved these changes
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the
infocommand was failing due to anon-standard
bind_hostsetting. Theinfocommand was alwaysattempting to reach the /debug/vars endpoint on
localhost. This wouldof course not work when the
bind_hostvalue was different.Fixes DataDog/dd-agent#3653