This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
obfuscate: add exception when parsing empty-string identifiers #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
approved these changes
Nov 5, 2018
| }, | ||
| { | ||
| `SELECT * FROM users WHERE firstname=""`, | ||
| `SELECT * FROM users WHERE firstname = ""`, |
There was a problem hiding this comment.
Sounds to me the problem is solved here, indeed.
| // This string is an empty or white-space only identifier. | ||
| // We should keep the start and end delimiters in order to | ||
| // avoid creating invalid queries. | ||
| // See: https://github.com/DataDog/datadog-trace-agent/issues/316 |
|
FYI Minor impact on time: |
|
Added another commit improving the white-space verification: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316