This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
config: use shared config for loading Agent 5 paths #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/guild-ini
branch
5 times, most recently
from
deab6b8 to
19befbc
Compare
gbbr
force-pushed
the
gbbr/guild-ini
branch
3 times, most recently
from
20b4858 to
e5ac28b
Compare
AlexJF
approved these changes
Nov 26, 2018
|
Thanks for the review! I will clean the confusing stuff up in the next PR. |
palazzem
reviewed
Dec 17, 2018
|
|
||
| [trace.sampler] | ||
| extra_sample_rate: 0.5 | ||
| max_traces_per_second: 5 | ||
| max_events_per_second: 50 | ||
|
|
||
| [trace.ignore] | ||
| resource: "/health,/500" | ||
| resource: "/health","/500" |
There was a problem hiding this comment.
@gbbr this is a breaking change that we introduced in a minor release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses shared config to load legacy
.conffile and removes all loading logic and dependencies. Repo size with vendor folder is now at 500MB. The size problem will be solved in the 6.9.0 release when we will merge into datadog-agent.Binary size now 21M (compared to master 20M).