Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, a non-ASCII character causes a failure when pip installing datadog.
I could not replicate on my local OSX machine, but I have a Docker image based on Ubuntu 14.04.5 LTS that fails reliably with the character in the README.
I would add a test, but the tests already fail in my Docker environment for the same reason, I'm not sure what exactly in the environment causes it.
Edit: I spent some time looking at the logic used to determine an encoding for
open()
when none is specified.On a Unix system, without
CODESET
available, it looks for four environment variables'LC_ALL', 'LC_CTYPE', 'LANG', 'LANGUAGE'
. If none of those are set, it defaults toascii
. The container where the build fails has none of those four set.While this is an environment issue, I still think it's worth changing the character, to match the other apostrophes in the file which all use the ASCII character.