Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Cloud integration endpoints #429

Merged
merged 34 commits into from
Nov 21, 2019
Merged

Add support for Cloud integration endpoints #429

merged 34 commits into from
Nov 21, 2019

Conversation

Ricky-Thomas
Copy link
Contributor

@Ricky-Thomas Ricky-Thomas commented Aug 23, 2019 •
edited
Loading

This PR adds the existing Cloud integration endpoints to the python client.

@Ricky-Thomas Ricky-Thomas requested a review from a team as a code owner August 23, 2019 18:29
@dabcoder
Copy link
Contributor

@Ricky-Thomas thanks for working on this! Looks like flake8 tests are failing, can you have a look at that then?

@Ricky-Thomas
Copy link
Contributor Author

Still a WIP. Working to make most recent failing tests pass.

@Ricky-Thomas Ricky-Thomas changed the title Add support for AWS integration endpoints Add support for Cloud integration endpoints Oct 1, 2019
nmuesch
nmuesch previously requested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks for this. Left a few pretty minor comments. Thanks!

datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_log_integration.py Outdated Show resolved Hide resolved
datadog/api/azure_integration.py Outdated Show resolved Hide resolved
datadog/api/azure_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_integration.py Outdated Show resolved Hide resolved
@Ricky-Thomas Ricky-Thomas requested a review from nmuesch October 10, 2019 18:31
zippolyte
zippolyte previously requested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive PR, thanks for the work !!
I inline a bunch of comments, let me know what you think.

datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_integration.py Outdated Show resolved Hide resolved
datadog/api/aws_log_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_logs.py Outdated Show resolved Hide resolved
tests/integration/api/test_aws_logs.py Outdated Show resolved Hide resolved
tests/integration/api/test_azure_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_azure_integration.py Show resolved Hide resolved
tests/integration/api/test_gcp_integration.py Outdated Show resolved Hide resolved
gzussa
gzussa suggested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR. 💯
Thanks for adding tests as well. more coverage = less issues
Please, also test your changes manually using the SDK.
Made some minor comments below.

tests/integration/api/utils.py Show resolved Hide resolved
tests/integration/api/test_gcp_integration.py Outdated Show resolved Hide resolved
tests/integration/api/test_azure_integration.py Outdated Show resolved Hide resolved
@Ricky-Thomas
Copy link
Contributor Author

The most recent refactoring work has surfaced a potential bug in the AWS Update endpoint on our side. I'm digging into this tomorrow and may still change the behavior for that here should I have to modify the endpoint in a way that warrants that. This PR can be considered a WIP still at this time. Thanks!

@dabcoder dabcoder mentioned this pull request Oct 28, 2019
Closed
@Ricky-Thomas
Copy link
Contributor Author

This PR is now ready for another review. The most recent changes address comments from both @zippolyte and @gzussa. The aforementioned potential bug in the AWS Update endpoint on our side has been fixed.

gzussa
gzussa reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I am not convinced with naming conventions tho.

datadog/api/__init__.py Outdated Show resolved Hide resolved
datadog/api/__init__.py Outdated Show resolved Hide resolved
@Ricky-Thomas Ricky-Thomas mentioned this pull request Nov 18, 2019
Merged
gzussa
gzussa approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo! 👏 Looks good to me. Let's make sure tests passes.

datadog/api/__init__.py Show resolved Hide resolved
@Ricky-Thomas
Copy link
Contributor Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ricky-Thomas Ricky-Thomas dismissed stale reviews from zippolyte and nmuesch November 20, 2019 19:07

Greg Zussa has approved this above

@zippolyte zippolyte merged commit 0f4051d into master Nov 21, 2019
@zippolyte zippolyte deleted the ricky-add_aws_endpoints_to_python_client branch November 21, 2019 09:42
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
@Ricky-Thomas
Add support for Cloud integration endpoints (DataDog#429)
94a5131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd left review comments

@zippolyte zippolyte zippolyte left review comments

@gzussa gzussa gzussa approved these changes

@nmuesch nmuesch Awaiting requested review from nmuesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ricky-Thomas @dabcoder @jd @gzussa @nmuesch @zippolyte