Add typing and configparser dependencies for python versions that need it
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython version. Fixes import errors when using `datadog` wheel build with Python versions older than 3.5. Fixes DataDog#571
zippolyte
added
the
changelog/Fixed
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
reviewed
Jun 23, 2020
Co-authored-by: Jiri Kuncar <[email protected]>
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
changed the title
typing and configparser dependencies regardless of Python versiontyping and configparser dependencies for python versions that need it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes import errors when using
datadogwheel build with Python versions older than 3.5.Fixes #571
Description of the Change
Adds explicit
typingandconfigparserdependencies regardless of Python version, in order to allow a singlepy2.py3wheel build to work correctly.Alternate Designs
An alternative solution is to create multiple wheel builds for Python < 3.5 and Python >= 3.5. This solution seemed simpler and doesn't require the build/release process to change.
Possible Drawbacks
There are two more lightweight dependencies that aren't actually necessary for Python 3.5+ installations.
Verification Process
I reproduced the import errors described in #571, and saw that they were fixed by installing
typingandconfigparser. I added the two new dependencies tosetup.pyand ran the unit and integration tests in Python 2.7 and 3.8. Finally, I created a wheel build and tested it in Python 2.7 and 3.5.Additional Notes
N/A
Release Notes
N/A
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.