-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[statsd] Add origin detection with container ID field #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8ee080
to
d9b9843
Compare
d9b9843
to
f0c3eff
Compare
vickenty
reviewed
Mar 7, 2022
sgnn7
reviewed
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmed-mez Left some comments but overall looks good
2446d43
to
ee27615
Compare
sgnn7
approved these changes
Mar 8, 2022
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
c:<id>
field holding the container ID so the agent can attach container tags.Description of the Change
DD_ENTITY_ID
is set, we ignore the container fieldDD_ENTITY_ID
is not set andDD_ORIGIN_DETECTION_ENABLED
is not explicitly set to false and theorigin_detection_enabled
param is not explicitly disabled, we try to get the app container ID by parsing/proc/self/cgroup
. In case of success, the container field in will be set.Alternate Designs
Possible Drawbacks
Verification Process
Wrote a small app importing the lib and sending metrics to agent 7.35 with origin detection client enabled - the metrics were tagged with container tags.
Additional Notes
Release Notes
Support adding the container ID field for origin detection (dogstatsd 1.2)
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.