varnish: allow multiple instances (fixes #490)

DataDog · Dec 23, 2013 · 0020988 · remh · Dec 23, 2013 · 0020988
1 parent 6a4b855
commit 0020988
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/checks.d/varnish.py b/checks.d/varnish.py
@@ -82,6 +82,7 @@ def check(self, instance):
         if instance.get("varnishstat", None) is None:
             raise Exception("varnishstat is not configured")
         tags = instance.get('tags', [])
+        name = instance.get('name')
 
         # Get the varnish version from varnishstat
         output, error = subprocess.Popen([instance.get("varnishstat"), "-V"],
@@ -114,6 +115,9 @@ def check(self, instance):
             arg = "-1"
 
         cmd = [instance.get("varnishstat"), arg]
+        if name is not None:
+            cmd.extend(['-n', name])
+            tags += [u'name:%s' % name]
         try:
             proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
                                          stderr=subprocess.PIPE)

diff --git a/conf.d/varnish.yaml.example b/conf.d/varnish.yaml.example
@@ -1,6 +1,13 @@
 init_config:
 
 instances:
-    -   varnishstat: /usr/bin/varnishstat
-#        tags:
-#            -   instance:production
+# - varnishstat: (required) String path to varnishstat binary
+#   name: (optional) String name of varnish instance. Passed to the -n parameter of varnishstat. Will also tag each metric with this name.
+#   tags: (optional) Additional tags to tag each metric with
+#
+# Example:
+#
+    - varnishstat: /usr/bin/varnishstat
+      name: myvarnishinstance
+      tags:
+        -   instance:production