Skip to content

Commit

Permalink
[trace-agent] adding output of 'trace-agent -info' (#3164)
Browse files Browse the repository at this point in the history
* [trace-agent] adding output of 'trace-agent -info' on 'datadog-agent info'

* [trace-agent] added support for CentOS

- Dropped source & OS/X patches, does not make sense yet
- Still returning 0 if trace-agent fails to get its status.
  Indeed, some might use this script as a health check, and
  we don't want it to fail just because the trace-agent is
  not working, as it's not a base core component (yet).

* [trace-agent] not checking for trace-agent binary, should be always shipped
  • Loading branch information
ufoot authored and talwai committed Feb 2, 2017
1 parent 1ecbe45 commit 90dfc24
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packaging/centos/datadog-agent.init
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ PIDPATH="/var/run/dd-agent/"
PROG="datadog-agent"
LOCKFILE=/var/lock/subsys/$PROG
FORWARDERPATH="/opt/datadog-agent/agent/ddagent.py"
TRACEAGENTPATH="/opt/datadog-agent/bin/trace-agent"
SUPERVISORD_PATH="PATH=/opt/datadog-agent/embedded/bin:/opt/datadog-agent/bin:$PATH /opt/datadog-agent/bin/supervisord"
SUPERVISORCTL_PATH="/opt/datadog-agent/bin/supervisorctl"
SUPERVISOR_CONF="/etc/dd-agent/supervisor.conf"
Expand Down Expand Up @@ -186,7 +187,9 @@ info() {
DOGSTATSD_RETURN=$?
su $AGENTUSER -c "$FORWARDERPATH info"
FORWARDER_RETURN=$?
exit $(($FORWARDER_RETURN+$COLLECTOR_RETURN+DOGSTATSD_RETURN))
su $AGENTUSER -c "$TRACEAGENTPATH -info"
TRACEAGENT_RETURN=$? # not used for now, Trace/APM not a core feature yet
exit $(($FORWARDER_RETURN+$COLLECTOR_RETURN+$DOGSTATSD_RETURN))
}

reload() {
Expand Down
3 changes: 3 additions & 0 deletions packaging/debian/datadog-agent.init
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ DOGSTATSDPATH="/opt/datadog-agent/agent/dogstatsd.py"
KILL_PATH="/opt/datadog-agent/embedded/bin/kill"
AGENTUSER="dd-agent"
FORWARDERPATH="/opt/datadog-agent/agent/ddagent.py"
TRACEAGENTPATH="/opt/datadog-agent/bin/trace-agent"
NAME="datadog-agent"
DESC="Datadog Agent"
SUPERVISOR_PIDFILE="/opt/datadog-agent/run/datadog-supervisord.pid"
Expand Down Expand Up @@ -176,6 +177,8 @@ case "$1" in
DOGSTATSD_RETURN=$?
su $AGENTUSER -c "$FORWARDERPATH info"
FORWARDER_RETURN=$?
su $AGENTUSER -c "$TRACEAGENTPATH -info"
TRACEAGENT_RETURN=$? # not used for now, Trace/APM not a core feature yet
exit $(($COLLECTOR_RETURN+$DOGSTATSD_RETURN+$FORWARDER_RETURN))
;;

Expand Down
3 changes: 3 additions & 0 deletions packaging/suse/datadog-agent.init
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ DOGSTATSDPATH="/opt/datadog-agent/agent/dogstatsd.py"
KILL_PATH="/opt/datadog-agent/embedded/bin/kill"
AGENTUSER="dd-agent"
FORWARDERPATH="/opt/datadog-agent/agent/ddagent.py"
TRACEAGENTPATH="/opt/datadog-agent/bin/trace-agent"
NAME="datadog-agent"
DESC="Datadog Agent"
SUPERVISOR_PIDFILE="/opt/datadog-agent/run/datadog-supervisord.pid"
Expand Down Expand Up @@ -417,6 +418,8 @@ case "$1" in
DOGSTATSD_RETURN=$?
su $AGENTUSER -c "$FORWARDERPATH info"
FORWARDER_RETURN=$?
su $AGENTUSER -c "$TRACEAGENTPATH -info"
TRACEAGENT_RETURN=$? # not used for now, Trace/APM not a core feature yet
exit $(($COLLECTOR_RETURN+$DOGSTATSD_RETURN+$FORWARDER_RETURN))
;;

Expand Down

0 comments on commit 90dfc24

Please sign in to comment.