Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[process] Correctly handle psutil.NoProcessFound when getting process state #1721

Closed
talwai opened this issue Jun 23, 2015 · 5 comments · Fixed by #1772
Closed

[process] Correctly handle psutil.NoProcessFound when getting process state #1721

talwai opened this issue Jun 23, 2015 · 5 comments · Fixed by #1772
Assignees
@talwai
Labels
bugfix checks

Comments

@talwai
Copy link
Contributor

talwai commented Jun 23, 2015

In situations where a process disappears after we discover its PID, we should be skipping over the subsequent interrogation of the process here. Currently the check is throwing errors like:

  File "/opt/datadog-agent/agent/checks.d/process.py", line 181, in get_process_state
    meminfo = self.psutil_wrapper(p, 'memory_info', ['rss', 'vms'])
UnboundLocalError: local variable 'p' referenced before assignment
@talwai talwai self-assigned this Jun 23, 2015
@DrTyrell
Copy link

We're seeing this too, thanks for attending to it.

@jsh2134
Copy link

jsh2134 commented Jul 15, 2015

+1 noticed this as well

talwai added a commit that referenced this issue Jul 15, 2015
@talwai
[checks.d][process] correctly handle disappearing pids
bb64aa2 
fixes #1721
@talwai talwai mentioned this issue Jul 15, 2015
Merged
@ssbarnea
Copy link

ssbarnea commented Sep 4, 2015

This calls for a minor release update ASAP, I do still get this with 5.3.4 which seems to be the latest version!

talwai added a commit that referenced this issue Sep 4, 2015
@talwai
[checks.d][process] correctly handle disappearing pids
da75221 
fixes #1721
@remh
Copy link

remh commented Sep 8, 2015

5.4.6 is released.

@ctrlrsf
Copy link

ctrlrsf commented Sep 10, 2015

Confirmed 5.4.6 fixed this for us. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talwai talwai

Labels
bugfix checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[checks.d][process] correctly handle disappearing pids DataDog/dd-agent
6 participants
@ssbarnea @DrTyrell @jsh2134 @remh @talwai @ctrlrsf